And the man Elkanah, and all his house
All his family, excepting Hannah, and her son Samuel; or all the men of his house, as the Targum; for only the males were obliged to appear at the three festivals:
went up to Shiloh;
to the house of God there:
to offer unto the Lord the yearly sacrifice;
either the passover, to which men commonly went up with their families: see ( Luke 2:41 Luke 2:42 ) , or rather it may be what was offered at the feast of tabernacles, as Abarbinel thinks, the time of the ingathering the fruits of the earth, when men went up with their families to offer sacrifice, and express their joy on that account, ( Deuteronomy 16:10-15 )
and his vow:
which he had made between feast and feast; for whatever vows men made at home, on any account, they paid them at the yearly festivals; and this vow might be on the account of the birth of his son, by way of thanksgiving for that.